Skip to content

Create hearing types per organization#1000

Merged
compwron merged 8 commits into
rubyforgood:masterfrom
haydenrou:create-hearing-types
Oct 11, 2020
Merged

Create hearing types per organization#1000
compwron merged 8 commits into
rubyforgood:masterfrom
haydenrou:create-hearing-types

Conversation

@haydenrou

@haydenrou haydenrou commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

This is my first attempt to hit the acceptance criteria for the attached issue. Please let me know if it falls short at any point.
Before this is ready to merge I had two questions:

  1. Would you like seeding for hearing types, if so for which environments, and what hearing type names? Reference: admins can customize hearing_types per casa_org #928 (comment)
  2. The last point on the acceptance criteria is " changes admins make here are reflected in hearing_types available to supervisors" - I don't understand what I need to do for this.

I plan on submitting a separate PR for #927 but wanted to get this first iteration out beforehand.

What github issue is this PR for, if any?

Resolves #928

What changed, and why?

There is now a crud(except delete) for hearing types accessible via the casa org edit page. Hearing types can be flagged as active or inactive.

How is this tested? (please write tests!) 💖💪

Via the edit org page, you can add a new hearing type or press the pencil to edit the hearing type.

Screenshots please :)

hearingtypes

@haydenrou haydenrou requested review from Zrrrpy and compwron October 7, 2020 18:02
@haydenrou haydenrou self-assigned this Oct 7, 2020
@compwron compwron marked this pull request as draft October 8, 2020 02:37
compwron
compwron reviewed Oct 8, 2020
View reviewed changes
Comment thread app/views/casa_orgs/edit.html.erb
compwron
compwron approved these changes Oct 8, 2020
View reviewed changes

@compwron compwron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very promising!

  • Please add another test for the data showing on the UI
  • Please fix the CI build :)

Feel free to drop in to chat in slack #casa https://rubyforgood.herokuapp.com/ for a faster response to questions :)

@haydenrou

haydenrou commented Oct 9, 2020

Copy link
Copy Markdown
Collaborator Author

These tests seem to be working locally for me, however some of the system ones seem to be somewhat flaky. Is there a way to retry CI without pushing up a change?

@compwron thanks for the feedback, I have added some specs.

@Zrrrpy looking forward to hearing your feedback here if you're happy with the approach, and what route you want to take regarding the seed data. If there is no conclusive answer yet, we could always add a backlog item and fill these in when we have better information.

When this has been approved and merged I'll make a start on #927

@compwron

compwron commented Oct 9, 2020

Copy link
Copy Markdown
Collaborator

@haydenrou the flaky build should be fixed now! You can usually re-run the build by clicking on the build and clicking re-run but I don't see the button right now. O.o Pushing a new change (or a rebase to master) will work.

@compwron compwron marked this pull request as ready for review October 9, 2020 13:49
@compwron

compwron commented Oct 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

it's a pain to rebase/merge master when you're working on a fork instead of a branch. I moved your code to a branch but didn't open the PR- click here to open a new PR with all the code from this PR (plus a merge of master) so that you can get the hacktoberfest opening-PR credit :) https://github.com/rubyforgood/casa/compare/create-hearing-types?expand=1

Here are instructions on fetching from upstream in case you would prefer to do that :) https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

@github-actions github-actions Bot added ruby Touches Ruby code Tests! 🎉💖👏 labels Oct 9, 2020
@haydenrou haydenrou added the zzz_archived: Hacktoberfest Do good, get swag. label Oct 10, 2020
@compwron compwron merged commit 7861d29 into rubyforgood:master Oct 11, 2020
@compwron

compwron commented Oct 11, 2020

Copy link
Copy Markdown
Collaborator

Very cool! Sorry for the delay on merging this.

Yes, seeding for hearing types would be great! For now only in dev/qa/staging, not in production. Be wary of the current discussion in slack about how we will change/combine/parameterize the seed files

@compwron compwron mentioned this pull request Oct 11, 2020
Closed
3 tasks
This was referenced Oct 11, 2020
Closed
Closed
@haydenrou haydenrou added the hacktoberfest-accepted Accepted for Hacktoberfest label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compwron compwron compwron approved these changes

@Zrrrpy Zrrrpy Awaiting requested review from Zrrrpy

Assignees

@haydenrou haydenrou

Labels

hacktoberfest-accepted Accepted for Hacktoberfest ruby Touches Ruby code zzz_archived: Hacktoberfest Do good, get swag.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

admins can customize hearing_types per casa_org

2 participants

@haydenrou @compwron